search

openSUSE / openSUSE-release-tools

Tools to aid in staging and release work for openSUSE/SUSE
GNU General Public License v2.0
57 stars 90 forks source link

cleanup_rings: whitelist 'devscripts' #3109

Closed DimStar77 closed 2 weeks ago

DimStar77 commented 3 weeks ago

devscripts has a sub-flavor for checknashisms that is required in Ring1 (for rpmlint) The flavor "" is technically not required, but removing the package would make the sub-flavor vanish as well.

DimStar77 commented 3 weeks ago

CC @ana - That should help cleanup_rings from wanting to break ring1

@Vogtinator Maybe we could teach the bot that package FOO:FLAVOR is needed, then removing FOO is a really bad idea ? :)

DimStar77 commented 3 weeks ago

At best the bot could mention that FOO is not needed and recommend to excludebuild it via prjconf - in some cases that might be a valid option (with the known risks of course)

ana commented 3 weeks ago

Works for me!

Vogtinator commented 3 weeks ago

@Vogtinator Maybe we could teach the bot that package FOO:FLAVOR is needed, then removing FOO is a really bad idea ?

It should already do that: https://github.com/openSUSE/openSUSE-release-tools/blob/9d63fee9d5db1490c7748d735ebbb538ac73607a/osclib/cleanup_rings.py#L211

This might fix it:

-if src.startswith(f"{mainpkg}:"):
+if src == mainpkg or src.startswith(f"{mainpkg}:"):

At best the bot could mention that FOO is not needed and recommend to excludebuild it via prjconf - in some cases that might be a valid option (with the known risks of course)

It does mention to exclude specific multibuild flavors for Ring 0 already.