openSUSE / openSUSE-release-tools

Tools to aid in staging and release work for openSUSE/SUSE
GNU General Public License v2.0
59 stars 92 forks source link

Ignore patchinfo packages when checking for duplicated binaries #3119

Closed boiko closed 4 weeks ago

boiko commented 1 month ago

In the staging areas used by maintenance, the patchinfo packages are staged together with the source packages, and because of the way they work, they collect binaries from the source packages around.

This causes binaries to be reported as duplicated, so ignore patchinfos.

adrianschroeter commented 1 month ago

On Freitag, 5. Juli 2024, 10:16:47 CEST Dirk Mueller wrote:

@dirkmueller commented on this pull request.

     for arch in list(duplicates):

for binary in self.ignore_duplicated: duplicates[arch].pop(binary, None) +

  • In maintenance stagings there are patchinfo packages which collect binaries from

  • other source packages. This leads to duplicate binaries being reported. So remove

  • any patchinfos from the comparison.

  • for package in list(duplicates[arch]):
  • filtered = [s for s in duplicates[arch][package] if not s.startswith("patchinfo")]

do they start with patchinfo: ? I personally would prefer to include the dot here at the end.

we have at least also a patchinfo_ga package atm.

--

Adrian Schroeter @.***> Build Infrastructure Project Manager

SUSE Software Solutions Germany GmbH, Frankenstraße 146, 90461 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev

adrianschroeter commented 1 month ago

sorry, got actually also renamed to patchinfo.ga meanwhile.

Vogtinator commented 1 month ago

IMO package_binary_list could just get another parameter next to exclude_src_debug=False to exclude patchinfo. Makes the implementation simpler.