search

openSUSE / openSUSEway

dotfiles for Sway on openSUSE
MIT License
82 stars 17 forks source link

Allow sway to be run with proprietary drivers #114

Closed joantolo closed 1 year ago

joantolo commented 1 year ago

Based on https://forum.endeavouros.com/t/sway-with-nvidia-tutorial/23733, these have been the changes needed to make it work.

FilippoBonazziSUSE commented 1 year ago

Hi, thanks for the PR.

This is something that only applies to a very specific subset of users (NVIDIA, proprietary drivers). As such, I don't think this is something that we want to make the default in openSUSEway.

I would be more interested to have a general mechanism to detect NVIDIA proprietary drivers in use at runtime, and only then add the specific workarounds to make sway work on that specific system.

joantolo commented 1 year ago

Hi. Is this okay?

FilippoBonazziSUSE commented 1 year ago

Hi, I hadn't noticed you had updated the PR. I would ask you to still change some stuff as it looks overcomplicated to me.

I would rather do without the complexity of the using-prop-drivers.sh helper script, which effectively could be reduced to a single grep command.

Also is there a reason why you're patching sway-run.sh with sed in the spec file and adding the .sh.in -> .sh step? Can't you just edit sway-run.sh in this PR?

joantolo commented 1 year ago

Ok, you are right, it can be less complicated with just a grep, thanks.

I was using sed to make obs set libexecdir and not hardcoding it directly, but now that the helper script is dropped it's not needed anymore.

FilippoBonazziSUSE commented 1 year ago

Looks much simpler now, thanks!