openSUSE / openSUSEway

dotfiles for Sway on openSUSE
MIT License
82 stars 17 forks source link

Consider shipping /usr/etc/xdg-desktop-portals/sway-portals.conf #134

Closed Arnavion closed 5 months ago

Arnavion commented 5 months ago

This is xdp's new preferred way to handle portals that have partial implementations, like xdpw is, and delegate unsupported features to other portals.

Ref:

For openSUSEway's case, I believe the xdpw example would be correct, ie use xdpw for screenshot and screencast but delegate everything else to xdp-gtk.

denisok commented 5 months ago

Hi @Arnavion ,

sway already ships: https://build.opensuse.org/package/view_file/X11:Wayland/sway/sway-portals.conf?expand=1

it was part of the fix: https://github.com/openSUSE/openSUSEway/pull/124#issuecomment-1748463071

stdden@stdlen:~> la -la /usr/share/xdg-desktop-portal/
total 8
drwxr-xr-x 1 root root   88 Jan 14 19:33 .
dr-xr-xr-x 1 root root 2500 Jan 29 09:52 ..
drwxr-xr-x 1 root root   40 Jan 14 19:33 portals
-rw-r--r-- 1 root root   28 Oct  5 03:58 sway-portals.conf
-rw-r--r-- 1 root root  301 Sep 28 10:05 wlroots-portals.conf
stdden@stdlen:~> la -la /usr/share/xdg-desktop-portal/portals/
total 8
drwxr-xr-x 1 root root  40 Jan 14 19:33 .
drwxr-xr-x 1 root root  88 Jan 14 19:33 ..
-rw-r--r-- 1 root root 458 Oct 24 20:29 gtk.portal
-rw-r--r-- 1 root root 197 Apr 15  2023 wlr.portal

We could have a different one if t will work and bring benefits.

Thanks, Denys

Arnavion commented 5 months ago

Oh, I did not check in sway package itself or in /usr/share/. Sorry for noise.

denisok commented 5 months ago

no problem! Thanks for caring! :)

denisok commented 5 months ago

btw - I see new "portals" dir - maybe that should be fixed and sway and wlr files should be moved?

Arnavion commented 5 months ago

The /usr/share/xdg-desktop-portal/sway-portals.conf path is correct. It is what the xdp doc says and also what the code looks for.

The portals subdirectory is where portals themselves, like xdpw, drop their UseIn= files.