Include pamixer in the pattern - Githubissues

openSUSE / openSUSEway

dotfiles for Sway on openSUSE

MIT License

82 stars 17 forks source link

Include pamixer in the pattern #32

Closed dive-deeper closed 3 years ago

dive-deeper commented 3 years ago

The sway configuration (/etc/sway/config.d/50-openSUSE.conf) uses pamixer to control the volume, however it is not included in the pattern (running Tumbleweed).

After manually installing with zypper, everything works as expected

jubalh commented 3 years ago

How did you install openSUSEway? https://build.opensuse.org/package/view_file/X11:Wayland/openSUSEway/openSUSEway.spec?expand=1 line 51 adds pamixer.

dive-deeper commented 3 years ago

Sorry, I confused sway-branding-openSUSE with openSUSEway (I installed the former). I am new to openSUSE so I don't know if you are also in charge of the patterns/branding/wiki but here are a couple suggestions in case any of them is possible:

Move pamixer to sway-branding-openSUSE: The sway configuration file that uses pamixer is included in this package and other dependencies like pavucontrol and brightnessctl are required/specified there too.
Change the wiki (https://en.opensuse.org/Sway) to recommend installing openSUSEway instead of sway-branding-openSUSE.

denisok commented 3 years ago

Hi @dionisiovj,

nice catch. I would further separate conf file, so pamixer part would be installed only with openSUSEway, so it wouldn't be confusing for ppl that just want some visual "sway" branding only.

Thanks, Denys

denisok commented 3 years ago

looked on specs and decided that right way to go is to add dependencies to spec as @dionisiovj suggested. Here are missed dependencies (from conf file) added: https://build.opensuse.org/request/show/864374

If there would be no objection or some review - I would land it tomorrow.

jubalh commented 3 years ago

Did you remove it (and the config) from sway-branding-openSUSE ?

denisok commented 3 years ago

I added missed packages to the sway-branding-openSUSE, it doesn't affect standard sway patterns. That conf also installed only with sway-branding-openSUSE.

jubalh commented 3 years ago

What about:

I would further separate conf file, so pamixer part would be installed only with openSUSEway, so it wouldn't be confusing for ppl that just want some visual "sway" branding only.

Sounded reasonable to me.

denisok commented 3 years ago

Sounded reasonable to me.

I looked into it, and there is already brightness control and etc. So actually it customizes Sway in a good way.

openSUSEway is more about DE env, including browser and etc.

Removing wob, brightness, pamixer and other stuff leaves almost none branding Sway experience.

denisok commented 3 years ago

OK, it is is on its way to Factory: https://build.opensuse.org/request/show/864611