search

openSUSE / opi

OBS Package Installer (CLI)
GNU General Public License v3.0
244 stars 22 forks source link

add yandex browser #108

Closed 13werwolf13 closed 2 years ago

13werwolf13 commented 2 years ago

due to the fact that yandex-browser is finally out of beta.

asdil12 commented 2 years ago

You have conflicting queries, so this won't work. Also it would make more sense to put this into a single file (and class) and ask the user, which version they want to install. Especially as the repo is the same for beta and stable. See https://github.com/openSUSE/opi/blob/master/opi/plugins/ms_edge.py for an example how this can be done.

13werwolf13 commented 2 years ago

You have conflicting queries, so this won't work. Also it would make more sense to put this into a single file (and class) and ask the user, which version they want to install. Especially as the repo is the same for beta and stable. See https://github.com/openSUSE/opi/blob/master/opi/plugins/ms_edge.py for an example how this can be done.

sorry but the repos are NOT the same. However, I understood what to do and will do. However, I did not understand about the conflict?

asdil12 commented 2 years ago

Oh yea - sorry the repo really seems to be different. But is should still work with a single class. I just don't want to clutter the list of plugins.

About the conflict:

queries = ('yandex-browser-stable', 'yandex-browser', 'yandex')
queries = ('yandex-browser-beta', 'yandex-browser', 'yandex')

... must not have entries that exist in any other plugin - how should opi otherwise know, which plugin it should run. I updated the testsuite to check for this case.

13werwolf13 commented 2 years ago

... must not have entries that exist in any other plugin - how should opi otherwise know, which plugin it should run. I updated the testsuite to check for this case.

now I understand. well, I thought that he would give a choice as in a normal text search. i was wrong. I will fix it and send a commit today, but a little later. Thanks.

13werwolf13 commented 2 years ago

@asdil12 I'm not sure if I did everything right, but I hope so.

13werwolf13 commented 2 years ago

@asdil12 sorry, i not know how do that

also please squash your changes into a single commit

i do

git rebase -i fd4008d7fb53a031a28e25c82b9a023871bcbe84
git push --force

and i get

Everything up-to-date

or should I delete this PR and create a new one from new branch?

13werwolf13 commented 2 years ago

ah, I figured out how to do it .. fixed.