openSUSE / opi

OBS Package Installer (CLI)
GNU General Public License v3.0
244 stars 22 forks source link

add openh264 #119

Closed 13werwolf13 closed 1 year ago

13werwolf13 commented 1 year ago

add open264 repo

13werwolf13 commented 1 year ago

it was only after I made the changes that I noticed that /usr/share/licenses/gstreamer-1.20-plugin-openh264 conflicts between the gstreamer-plugins-bad-codecs and gstreamer-1.20-plugin-openh264 packages. so I created a pr in draft. I think I need to contact the maintainer of the gstreamer-plugins-bad-codecs package in the packman repo to rule out this conflict. but I don't know how to do it.

13werwolf13 commented 1 year ago

I write email to packman@links2linux.de and am awaiting a response. I will be glad if someone more knowledgeable can help.

DarkWav commented 1 year ago

it was only after I made the changes that I noticed that /usr/share/licenses/gstreamer-1.20-plugin-openh264 conflicts between the gstreamer-plugins-bad-codecs and gstreamer-1.20-plugin-openh264 packages. so I created a pr in draft. I think I need to contact the maintainer of the gstreamer-plugins-bad-codecs package in the packman repo to rule out this conflict. but I don't know how to do it.

This file conflict should be resolved with this request: https://pmbs.links2linux.org/request/show/5684 (gstreamer-plugins-bad-codecs >= 1.22.0-2.1) Can you try again and check if installing gstreamer-plugins-bad-codecs and gstreamer-1.20-plugin-openh264 simultaneously works now?

13werwolf13 commented 1 year ago

it was only after I made the changes that I noticed that /usr/share/licenses/gstreamer-1.20-plugin-openh264 conflicts between the gstreamer-plugins-bad-codecs and gstreamer-1.20-plugin-openh264 packages. so I created a pr in draft. I think I need to contact the maintainer of the gstreamer-plugins-bad-codecs package in the packman repo to rule out this conflict. but I don't know how to do it.

This file conflict should be resolved with this request: https://pmbs.links2linux.org/request/show/5684 (gstreamer-plugins-bad-codecs >= 1.22.0-2.1) Can you try again and check if installing gstreamer-plugins-bad-codecs and gstreamer-1.20-plugin-openh264 simultaneously works now?

so, for tumbleweed this work but not for leap

13werwolf13 commented 1 year ago

and for leap need be removed $releasever from repo uri

DarkWav commented 1 year ago

it was only after I made the changes that I noticed that /usr/share/licenses/gstreamer-1.20-plugin-openh264 conflicts between the gstreamer-plugins-bad-codecs and gstreamer-1.20-plugin-openh264 packages. so I created a pr in draft. I think I need to contact the maintainer of the gstreamer-plugins-bad-codecs package in the packman repo to rule out this conflict. but I don't know how to do it.

This file conflict should be resolved with this request: https://pmbs.links2linux.org/request/show/5684 (gstreamer-plugins-bad-codecs >= 1.22.0-2.1) Can you try again and check if installing gstreamer-plugins-bad-codecs and gstreamer-1.20-plugin-openh264 simultaneously works now?

so, for tumbleweed this work but not for leap

I made a request to fix it for Leap 15.4, too: https://pmbs.links2linux.org/request/show/5685 Leap 15.3 is EOL so it shouldn't matter there.

13werwolf13 commented 1 year ago

so, i do some changes. now that's code work on tumbleweed and leaap to. thanx @NikitaBeloglazov for the python advice pr can be approwed after that

DarkWav commented 1 year ago

pr can be approwed after that

Packman SR was accepted, so we are good to go, right?

13werwolf13 commented 1 year ago

pr can be approwed after that

Packman SR was accepted, so we are good to go, right?

in the morning I double-checked everything on clean, freshly created lxc containers. I confirm that both leap and tumbleweed work correctly.

13werwolf13 commented 1 year ago

as I understand it, it's time to invite @asdil12 to this thread

lkocman commented 1 year ago

Just please keep in mind that we use version-less Leap repository. I'm not sure to what %project espands in the changes. So I'm rather raising the fact.

lkocman commented 1 year ago

One thing to keep in mind is that users, who will do a new install of Leap 15.5 or TW will have repository enabled by default.

asdil12 commented 1 year ago

@13werwolf13 I pushed some changes to this PR on my own to detect if the openh264 repo is already present as @lkocman mentioned. Could you have another check if it works? Please also test if it works when the openh264 repo is already added but has a name (repo name in the .repo file contents and filename of the .repo file) other than openh264.

13werwolf13 commented 1 year ago

@asdil12 I downloaded the repo file directly from the repository, it has a different name. the definition seemed to work correctly, but I see it. So far I don't understand what went wrong.

image

the behavior is the same for both leap and tumbleweed

asdil12 commented 1 year ago

Could you show me an ls of your /etc/zypp/repos.d directory and the contents of the openh264 repo file?

asdil12 commented 1 year ago

In the meantime I think I found the issue and pushed some fixes. Could you try again with the latest version?

13werwolf13 commented 1 year ago

In the meantime I think I found the issue and pushed some fixes. Could you try again with the latest version?

image

now it works as it should!

thanks for your work!

13werwolf13 commented 1 year ago

@asdil12 a question from the community: in what release will these changes be (how soon to expect in the distribution's repositories)?

asdil12 commented 1 year ago

The changes are included in opi 2.13.0. For tumbleweed it depends when the submit request (https://build.opensuse.org/request/show/1065419) is accepted. It should be merged in the next two days or so. Then it is in Factory and the next (successfully tested) snapshot of Factory will be released as tumbleweed. That usually happens every two to three days. So I would expect it to hit tumbleweed next week.

If you want to try it out earlier, you can install the newest version of opi from the utilities devel repo using opi ;).

asdil12 commented 1 year ago

Another SR as it turns out that libcurl doesn't like a redirect from the https repo to the http cisco CDN: https://build.opensuse.org/request/show/1065545

The url for the gpgkey stays https.