search

openSUSE / osc

The Command Line Interface to work with an Open Build Service
http://openbuildservice.org/
GNU General Public License v2.0
170 stars 185 forks source link

spammy pkglistgen due to a deprecation warning in osc/connecton.py #1239

Closed lkocman closed 1 year ago

lkocman commented 1 year ago

Describe the bug We seem to be using deprecated call in osc/connection.py API which results into thousands of lines of "converted retries value" Converted retries value: 3 -> Retry(total=3, connect=None, read=None, redirect=None, status=None)

@DimStar77 mentioned that this only happens with --debug which seems to be the case on botmaster.

He uses following as a local workaround pool_kwargs["retries"] = urllib3.Retry(total=int(conf.config["http_retries"])) in osc/connection.py, line 220 He's worried that it might not work on older versions of urlllib3

Versions latest version of osc

To Reproduce Steps to reproduce the behavior: Trigger e.g. 15.5 pkglistgen with --debug (which is default on botmaster) which then uses osc.connecction https://botmaster.suse.de/go/tab/build/detail/Pkglistgen.openSUSE_Leap_15.5/2417/pkglistgen/1/openSUSE_Leap_15.5_target

Expected behavior not thousands of "converted retries value 3 -> into" notifications in the log

DEBUG:urllib3.util.retry:Converted retries value: 3 -> Retry(total=3, connect=None, read=None, redirect=None, status=None) DEBUG:urllib3.connectionpool:https://api.opensuse.org:None "GET /source/openSUSE:Leap:15.5/000update-repos/config.yml?rev=199 HTTP/1.1" 200 4197 DEBUG:urllib3.util.retry:Converted retries value: 3 -> Retry(total=3, connect=None, read=None, redirect=None, status=None) DEBUG:urllib3.connectionpool:https://api.opensuse.org:None "GET /source/openSUSE:Leap:15.5/000update-repos/_meta HTTP/1.1" 200 None DEBUG:root:-> do_update DEBUG:urllib3.util.retry:Converted retries value: 3 -> Retry(total=3, connect=None, read=None, redirect=None, status=None) DEBUG:urllib3.connectionpool:https://api.opensuse.org:None "GET /source/openSUSE:Leap:15.5/_meta HTTP/1.1" 200 None

Screenshots, console outputs spammy_pkglistgen

Additional context Add any other context about the problem here.

dmach commented 1 year ago

He uses following as a local workaround pool_kwargs["retries"] = urllib3.Retry(total=int(conf.config["http_retries"])) in osc/connection.py, line 220 He's worried that it might not work on older versions of urlllib3

None if the tests failed, let's give it a try. If there's an unexpected compatibility issue, we'll fix it later.