openSUSE / osc

The Command Line Interface to work with an Open Build Service
http://openbuildservice.org/
GNU General Public License v2.0
169 stars 181 forks source link

Wrong error message from osc "'can't open control.tar.zst without python-zstandard" #1607

Closed Bischoff closed 3 days ago

Bischoff commented 1 month ago

Issue Description

When compiling Debian packages without python3-zstandard package installed, one gets the error message

can't open control.tar.zst without python-zstandard

Same problem for LZMA:

can't open control.tar.xz without python-lzma

Expected Result

can't open control.tar.zst without python3-zstandard

and same for ZLMA.

How to Reproduce

With a Debian package, use e.g. this command

osc build xUbuntu_24.04

Further Information

source code:

https://github.com/openSUSE/osc/blob/d8bfd4521e724983e6b9acf49f85c2891a756bfd/osc/util/debquery.py#L100

dmach commented 4 weeks ago

I'm going to add weak dependencies on the packages to the spec file, so they get installed by default. Would that work for you?

Bischoff commented 3 weeks ago

Of course, it would, thank you Daniel.

dmach commented 1 week ago

lzma seems to be part of the standard python library that's why I only added Recommends: %{use_python_pkg}-zstandard