osc vc error with meego/rpm changelog style

[V-Z]

When updating an older package having its muscle.changes (in this example, probably output of rpm -q --changelog) like

* Sat Apr 23 2011 Vimalkumar Velayudhan <vim...@bio...org> 3.8.31-1
- Update to version 3.8.31

* Fri Dec 18 2009 - Vimalkumar Velayudhan <vim...@bio...org> - 3.7-1
- Initial package created

running osc vc end with Error: you need meego-packaging-tools for /usr/bin/vc command.

After removing that file, osc vc worked as expected, producing

-------------------------------------------------------------------
Thu Jan 20 13:51:45 UTC 2022 - Vojtech Zeisek <Vo...@op...org>

Updated to Muscle 5.1. Disabled static linking.
...

Notes from discussion in IRC opensuse-buildesrvice

• well yes, the meego changelog style is what triggers it; ^\*\W+(.+\W+\d{1,2}\W+20\d{2})\W+(.+)\W+<(.+)>\W+(.+)$; problem is that current suse style is the same meanwhile at this point; so, not really possible to detect if it is meego or suse style that way
• The SUSE style is quite distinct from meego/rpm. In suse, the date starts at ^ and prefix by a -{66} line or so. in meego/rpm, the date starts after ^\*\

[Thaodan]

The error is triggered from this commit: https://github.com/openSUSE/osc/commit/c61e4a514ee0128d78f8598a23e78b6684913a56.

I wonder if this check is needed and if osc simply should manage these logs itself.

[dmach]

I'd prefer not to build any workarounds around vc in osc, because the problem would be fixed in one tool only. That's why I believe this belongs to vc tool in https://github.com/openSUSE/obs-build

[mcepl]

Isn’t Meego completely dead, buried, not even smelling any more?

[Thaodan]

Isn’t Meego completely dead, buried, not even smelling any more?

The changelog style is still used in regular RPM Redhat style and in Sailfish OS.

[Thaodan]

I'd prefer not to build any workarounds around vc in osc, because the problem would be fixed in one tool only. That's why I believe this belongs to vc tool in https://github.com/openSUSE/obs-build

I think you confuse the SUSE vc and the Meego/Intel vc. Osc refers to the latter I think.

However meego style could be added to this vc from the original meego vc.

I couldn't find any archive of the Meego vc besides the Debian source mirror: https://bazaar.launchpad.net/~ubuntu-branches/debian/sid/meego-packaging-tools/sid/view/head:/bin/vc

Using that script osc works as intended.

Also I'm not sure if it makes sense to extended the SUSE vc when osc itself doesn't even use it for the SUSE changelog style?