search

openSUSE / osc2

The next Command Line Interface to work with an openSUSE Build Service
http://openbuildservice.org/
17 stars 9 forks source link

Do not pass tuples to MirrorGroup. #30

Closed bergmannf closed 6 years ago

bergmannf commented 6 years ago

Pass a list[str] as the mirrors argument.

Update the logic derived from urlgrabber components to split the received strings into the three-tuple (host, path, query) as needed.

This partially resolves #29 (4 tests remain failing for me).

Given that this changes code interfacing with urlgrabber I assume I might also just be using an unsupported version of that dependency, where the interfaces were changed.

marcus-h commented 6 years ago

On 2017-12-12 12:42:02 +0000, Florian Bergmann wrote:

Pass a list[str] as the mirrors argument.

Update the logic derived from urlgrabber components to split the received strings into the three-tuple (host, path, query) as needed.

This partially resolves #29 (4 tests remain failing for me).

Given that this changes code interfacing with urlgrabber I assume I might also just be using an unsupported version of that dependency, where the interfaces were changed.

Hmm I just had a quick glance at it: the current code breaks the python-urlgrabber 3.9.1 support.