openSUSE / osem

Open Source Event Manager. An event management tool tailored to Free and Open Source Software conferences.
http://osem.io
MIT License
879 stars 493 forks source link

Dates format in xml is incorrect #2510

Closed Ana06 closed 5 years ago

Ana06 commented 5 years ago

From @danimo in https://github.com/openSUSE/osem/issues/2497#issuecomment-487918981:

It seems the timestamp format has changed:

14:0: ERROR: Element 'date': '2019-05-24 09:30 Berlin' is not a valid value of the atomic type 'dateTimeTZ'.

It should looke like this: 2019-05-24T09:30:00+02:00

From the XSD:

  <xs:simpleType name="dateTimeTZ">
    <xs:restriction base="xs:dateTime">
      <xs:pattern value=".+(Z|\+[0-9]{1,2}:[0-9]{2}|-[0-9]{1,2}:[0-9]{2})"/>
    </xs:restriction>
  </xs:simpleType>

(it also complains about the GUID field not satisfying the regex [0-9a-fA-F]{8}(-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12} (i.e. not being a true UUID) but I am not sure that was ever different. The validator and a link to the XSD is here: https://c3voc.de/schedulexml.

danimo commented 5 years ago

Just an idea: If you want to create a test, and assuming osem has a mock for a complete conference schedule, the schedule.xml route could be checked against https://raw.githubusercontent.com/voc/schedule/master/validator/xsd/schedule.xml.xsd to avoid future breakage. If you want that as a new issue, that's fine.

Ana06 commented 5 years ago

@danimo

If you want that as a new issue, that's fine.

It is a good idea, please open a new issue, so that we can fast fix the bug by now.

danimo commented 5 years ago

Done, see #2514. If someone could reload the webserver, we can close this issue.

Ana06 commented 5 years ago

@danimo I have deployed, please double check that the issue is fixed

danimo commented 5 years ago

Works like a charm, thanks!