search

openSUSE / pesign-obs-integration

GNU General Public License v2.0
7 stars 21 forks source link

Enable find_provides and requires #14

Closed bmwiedemann closed 5 years ago

bmwiedemann commented 5 years ago

Enable find_provides and requires to get automatic provides instead of manual ones like the original package did

Without this patch, rpm -qpv --provides $rpm differed significantly between OBS build and local osc build.

filterdiff "rpm -qpv --provides" binaries*/fwupd-1.2.3-*.x86_64.rpm
--- filter/binaries/fwupd-1.2.3-42.6.x86_64.rpm
+++ filter/binaries.nachbau/fwupd-1.2.3-42.6.x86_64.rpm
@@ -1,4 +1,3 @@
-manual: config(fwupd) = 1.2.3-42.6
 config: config(fwupd) = 1.2.3-42.6
 manual: fwupd = 1.2.3-42.6
...
-manual: libfu_plugin_altos.so()(64bit)
-manual: libfu_plugin_amt.so()(64bit)
+auto: libfu_plugin_altos.so()(64bit)
+auto: libfu_plugin_amt.so()(64bit)

Fixes part of issue #9

lcp commented 5 years ago

Would this patch handle the customized %find_priovide scripts?

bmwiedemann commented 5 years ago

Not sure. Do you have an example for such a package? I checked the ones in https://build.opensuse.org/project/show/home:bmwiedemann:reproducible:pesign and it worked there.

lcp commented 5 years ago

Ok, I will try to find a package with the customized find_provide script and see how it works.

lcp commented 5 years ago

I found that no user of pesign-obs-integration uses the customized find_* scripts, so maybe I just worried too much.

bmwiedemann commented 5 years ago

For the record: 7ff02118bb146561ca164c84431a084895a06626 reverted this because of VirtualBox