openSUSE / py2pack

Generate distribution packages from PyPI
Apache License 2.0
69 stars 40 forks source link

No scripts fix #105

Closed iyuroch closed 5 years ago

iyuroch commented 6 years ago

Add if statement in jinja to see if there are scripts. If there is are no scripts - continue.

sebix commented 6 years ago

Fail in the tests:

TemplateAssertionError: no test named 'None'

I guess that the tests would still fail if the above is fixed as you added two newlines.

toabctl commented 5 years ago

Can you squash your commits please?

sebix commented 5 years ago

@toabctl After a merge with master, the tests are succeeding

sebix commented 5 years ago

8 days ago I tested the merge of this branch with master and it worked (because master had the tes fixes). @toabctl can you please specify what does still fail?

toabctl commented 5 years ago

8 days ago I tested the merge of this branch with master and it worked (because master had the tes fixes). @toabctl can you please specify what does still fail?

Travis - See the box bellow the merge button (this link: https://travis-ci.org/openSUSE/py2pack/builds/539254302?utm_source=github_status&utm_medium=notification )

toabctl commented 5 years ago

Maybe a rebase is needed to include the date fixes for the spec templates?

sebix commented 5 years ago

@toabctl Either: First @iyuroch merges in master, then you merge the PR Or: You merge the PR

Result is the smae

toabctl commented 5 years ago

@sebix hm. I can't follow. Travis is red and imo it should be fixed before merging anything. Is there already a fix for that somewhere?

sebix commented 5 years ago

Is there already a fix for that somewhere?

master

toabctl commented 5 years ago

master

then why is travis still red here?

sebix commented 5 years ago

master

then why is travis still red here?

Because it only checks the PR itself, not it's merge in master. However, it could be configured to also check the merge ("pull").

toabctl commented 5 years ago

@sebix a rebase should be enough. @iyuroch could you do that please?

toabctl commented 5 years ago

tests executed locally - works. thanks!