Closed iyuroch closed 5 years ago
Fail in the tests:
TemplateAssertionError: no test named 'None'
I guess that the tests would still fail if the above is fixed as you added two newlines.
Can you squash your commits please?
@toabctl After a merge with master, the tests are succeeding
8 days ago I tested the merge of this branch with master and it worked (because master had the tes fixes). @toabctl can you please specify what does still fail?
8 days ago I tested the merge of this branch with master and it worked (because master had the tes fixes). @toabctl can you please specify what does still fail?
Travis - See the box bellow the merge button (this link: https://travis-ci.org/openSUSE/py2pack/builds/539254302?utm_source=github_status&utm_medium=notification )
Maybe a rebase is needed to include the date fixes for the spec templates?
@toabctl Either: First @iyuroch merges in master, then you merge the PR Or: You merge the PR
Result is the smae
@sebix hm. I can't follow. Travis is red and imo it should be fixed before merging anything. Is there already a fix for that somewhere?
Is there already a fix for that somewhere?
master
master
then why is travis still red here?
master
then why is travis still red here?
Because it only checks the PR itself, not it's merge in master. However, it could be configured to also check the merge ("pull").
@sebix a rebase should be enough. @iyuroch could you do that please?
tests executed locally - works. thanks!
Add if statement in jinja to see if there are scripts. If there is are no scripts - continue.