search

openSUSE / py2pack

Generate distribution packages from PyPI
Apache License 2.0
69 stars 40 forks source link

Documentation & additional tests for utils.py #108

Closed dcermak closed 5 years ago

dcermak commented 5 years ago

The major change proposed is that _get_archive_filelist now raises a ValueError instead of a Exception, which is (afaik) considered bad style.

toabctl commented 5 years ago
dcermak commented 5 years ago

Thomas Bechtold notifications@github.com writes:

  • travis is unhappy

Yes, sorry about that. I tried to run tox locally, but the error did not show up on my box (I believe it's because I was using python3's pep8).

  • would be nice to have a why in the commit msg for each commit

I have added some further explanations to the commits.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/openSUSE/py2pack/pull/108#issuecomment-447356034