license is UNKNOWN if nothing determined

openSUSE / py2pack

Generate distribution packages from PyPI

Apache License 2.0

69 stars 40 forks source link

license is UNKNOWN if nothing determined #123

Closed sebix closed 3 years ago

sebix commented 5 years ago

set license field to UNKNOWN instead if empty string to prevent silent errors fixes openSUSE/py2pack#119

scarabeusiv commented 5 years ago

People are stubborn, I wonder if they would not be happy enough with UNKNOWN license to submit it, maybe something like FIXME-UNKNONWN would be better?

thesp0nge commented 3 years ago

In both cases (with UNKNOWN or an empty field), rpmlint will complain when building the package. Are we sure we need this?

sebix commented 3 years ago

The idea back then (I didn't even remember that PR...) was, that by using such a value it is more clear that the packages needs to fill it and - more important - the license was unknown to pypack (thus, giving a reason to the py2pack-user, not just silently do nothing).

mcepl commented 3 years ago

I think I like @scarabeusiv ’s idea. FIXME UNKNOWN is an obvious command, and if push comes to shove we can search for it and indicate faulty packages.

sebix commented 3 years ago

PR is now changed to FIXME-UNKOWN.

The test fail RuntimeError: PyPI's XMLRPC API is currently disabled due to unmanageable load and will be deprecated in the near future. looks unrelated.