search

openSUSE / py2pack

Generate distribution packages from PyPI
Apache License 2.0
69 stars 40 forks source link

Compare generated specfiles with saved output #87

Closed sebix closed 7 years ago

sebix commented 7 years ago

Based on previous PR #86

Requires internet access

Easily detects whitespaces issues as those raised in openSUSE/py2pack#82 but it's a bit more effort to change them.

toabctl commented 7 years ago

@sebix is this still needed?

sebix commented 7 years ago

What do you mean with "still"? It is a proposal to check for complete files, not just single functions. Allows detecting whitespace issues, which is why I implemented it and what I used it for.

toabctl commented 7 years ago

@sebix I'm confused. I already accepted PR#86 and the first 4 commits are already in master. Why is github showing all theses commits?

sebix commented 7 years ago

On 08/30/2017 04:26 PM, Thomas Bechtold wrote:

@sebix https://github.com/sebix I'm confused. I already accepted PR#86 and the first 4 commits are already in master. Why is github showing all theses commits?

Github does not refresh this kind of diff, but it does not matter. Git itself does it correctly.