Using the @review:acceptable_for:incident_<incident>:<reason> label for manually approving job alone does not mark the jobs as unblocked in the dashboard, if there are other jobs still failing.
I've used the @review:acceptable_for:incident_<incident>:<reason> label to unblock tests from one job group e.g. A. The bot recognised the label, however A remains marked in red if there is still a failure in job group B.
From the output:
2024-02-15 12:59:28 INFO Job setting <redacted> not found for incident <redacted>
2024-02-15 12:59:28 INFO Found failed, not-ignored job https://openqa.suse.de/<redacted> for incident <redacted>
2024-02-15 12:59:28 INFO SUSE:Maintenance:<redacted>:<redacted> has at least one failed job in incident tests
In the dashboard I can see the following:
Here, all jobs in "Containers Maintenance" have been approved for this incident using @review:acceptablefor:incident:`, however the visible state is not being updated.
Using the
@review:acceptable_for:incident_<incident>:<reason>
label for manually approving job alone does not mark the jobs as unblocked in the dashboard, if there are other jobs still failing.I've used the
@review:acceptable_for:incident_<incident>:<reason>
label to unblock tests from one job group e.g.A
. The bot recognised the label, howeverA
remains marked in red if there is still a failure in job groupB
.From the output:
In the dashboard I can see the following:
Here, all jobs in "Containers Maintenance" have been approved for this incident using @review:acceptablefor:incident:`, however the visible state is not being updated.