openSUSE / qem-dashboard

A graphical user interface add-on for openSUSE/qem-bot
GNU General Public License v2.0
8 stars 14 forks source link

Dashboard status is not updated by comment #829

Open grisu48 opened 7 months ago

grisu48 commented 7 months ago

Using the @review:acceptable_for:incident_<incident>:<reason> label for manually approving job alone does not mark the jobs as unblocked in the dashboard, if there are other jobs still failing.

I've used the @review:acceptable_for:incident_<incident>:<reason> label to unblock tests from one job group e.g. A. The bot recognised the label, however A remains marked in red if there is still a failure in job group B.

From the output:

2024-02-15 12:59:28 INFO     Job setting <redacted> not found for incident <redacted>
2024-02-15 12:59:28 INFO     Found failed, not-ignored job https://openqa.suse.de/<redacted> for incident <redacted>
2024-02-15 12:59:28 INFO     SUSE:Maintenance:<redacted>:<redacted> has at least one failed job in incident tests

In the dashboard I can see the following:

image

Here, all jobs in "Containers Maintenance" have been approved for this incident using @review:acceptablefor:incident:`, however the visible state is not being updated.

kraih commented 7 months ago

The dashboard does not deal with labels, it only displays what information the qem-bot forwards to its API.