Skip more tests related to old OpenSSL algorithms

ycedres commented 2 months ago

What does this PR do?

There are some more tests failing in the test suite due to old OpenSSL versions that do not support some algorithms like ed25519.

The same approach was followed in https://github.com/openSUSE/salt/pull/646.

What issues does this PR fix or reference?

Tracks: https://github.com/SUSE/spacewalk/issues/23286

Previous Behavior

Failing tests on systems with old OpenSSL.

New Behavior

Unsupported algorithms skipped on systems with old OpenSSL.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

[ ] Docs
[ ] Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
[ ] Tests written/updated

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

vzhestkov commented 2 months ago

I just found few more tests which seem failing due to the same reason:

FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[None-der-ed25519] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[None-der-ed448] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[None-pem-ed25519] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[None-pem-ed448] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[hunter1-der-ed25519] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[hunter1-der-ed448] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[hunter1-pem-ed25519] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[hunter1-pem-ed448] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed_algo_change[existing_pk0] - assert False
ERROR tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed_existing[existing_pk2] - assert False
ERROR tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed_existing[existing_pk3] - assert False

These tests are marked as slow. @ycedres could you please take a look on them also? I think they could be fixed similar way.

ycedres commented 2 months ago

I just found few more tests which seem failing due to the same reason:

FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[None-der-ed25519] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[None-der-ed448] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[None-pem-ed25519] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[None-pem-ed448] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[hunter1-der-ed25519] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[hunter1-der-ed448] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[hunter1-pem-ed25519] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[hunter1-pem-ed448] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed_algo_change[existing_pk0] - assert False
ERROR tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed_existing[existing_pk2] - assert False
ERROR tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed_existing[existing_pk3] - assert False

These tests are marked as slow. @ycedres could you please take a look on them also? I think they could be fixed similar way.

@vzhestkov I included also those tests as you suggested.

openSUSE / salt