openSUSE / salt

openSUSE and SUSE patches and backports for SaltStack
Apache License 2.0
22 stars 52 forks source link

Fix x509 private key tests and test_suse on SLE12 #684

Closed m-czernek closed 1 week ago

m-czernek commented 1 week ago

What does this PR do?

This PR is related to https://github.com/openSUSE/salt/pull/682.

For x509 tests, I forgot to include two tests.

For the test_suse.py test, the problem there is that on SLE12, none of the if/else paths matched. I simplified it so that we use the SLE15 SP4 repo URL, since the tests check whether we can manipulate with repositories (e.g. add, modify, remove, ...) but does not install any packages (so the repository URL shouldn't matter, we just need to provide one)

What issues does this PR fix or reference?

Relates to: https://github.com/SUSE/spacewalk/issues/23286

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.