search

openSUSE / software-o-o

The site behind https://software.opensuse.org. It is the default web interface to download openSUSE distributions and to search for OBS packages. Packaged at https://build.opensuse.org/project/show/openSUSE:infrastructure:software.opensuse.org
https://software.opensuse.org/
GNU General Public License v2.0
139 stars 111 forks source link

URL to Debian Release.key is wrong #1273

Open faho opened 1 year ago

faho commented 1 year ago

Describe the bug The instructions to add a Debian repository have the wrong url to the release key.

Instead of e.g. https://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_10/Release.key they look like https://download.opensuse.org/repositories/shells:fish:release:3/Debian_10/Release.key - the "/" between "shells:" and "fish:" and "release:" are missing, causing it to 404.

The instructions look like

echo 'deb http://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_9.0/ /' | sudo tee /etc/apt/sources.list.d/shells:fish:release:3.list
curl -fsSL https://download.opensuse.org/repositories/shells:fish:release:3/Debian_9.0/Release.key | gpg --dearmor | sudo tee /etc/apt/trusted.gpg.d/shells_fish_release_3.gpg > /dev/null

The repository line is correct, the Release.key line isn't.

It seems this is caused by https://github.com/openSUSE/software-o-o/blob/ce99b8e91d4d7410a44699f0c4a552e061250949/app/views/download/package.erb#L64 doing some replacement on the repo for the echo deb part, but not the later curl part.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://software.opensuse.org/download.html?project=shells%3Afish%3Arelease%3A3&package=fish'
  2. Click on 'Debian', then 'Add repository'
  3. See error

Expected behavior The link is correct.

Environment (please complete the following information):

Additional context N/A

FWDekker commented 11 months ago

I think this issue has since been fixed. Though the PR has not been merged and though the URLs has not changed, it looks like the link no longer 404s. Probably a back-end change?