search

openSUSE / supportutils

SUSE Linux Enterprise support utilities. Gathers system information.
29 stars 62 forks source link

Modify usage of df command within supportconfig #141

Closed markgharvey closed 2 years ago

markgharvey commented 2 years ago

► Enhancement Request -- modify usage of df in the supportconfig report generation utility to include file system type via the df command -T switch

• Files in the supportconfig report where df is used

basic-health-check.txt fs-btrfs.txt

• current usage /bin/df -h

• requested enhancement usage /bin/df -Th

g23guy commented 2 years ago

SUSE.getFilesystems (python) and SDP::Core::getFileSystems (perl) libraries both depend on basic-health-check.txt's df -h and its column order. There are several patterns that use that function. Those libraries would need to be modified to account for the new Type column in the df output. Not impossible, but would take some work.

markgharvey commented 2 years ago

Perhaps another option would be to leave the current usage of /bin/df -h in place as it's output is being consumed by other functions.

Then run /bin/df -Th separately ; dumping output to one or both of these files. basic-health-check.txt fs-btrfs.txt

g23guy commented 2 years ago

I'll add it to fs-diskio.txt. It is a natural next step from basic info to more detailed information.

g23guy commented 2 years ago

I can also modify fs-btrfs.txt and drbd.txt to include the type.

markgharvey commented 2 years ago

Using the fs-*.txt files should work well. drbd.txt too.
Nice to have the file system type next to the storage data & mount points.
Appreciate the modifications to provide this enhancement.

g23guy commented 2 years ago

commit 33d659750880d924773d0eefaa9d7614645c60f1 (HEAD -> 3121, origin/3121) Author: Jason Record g23guy@gmail.com Date: Tue Oct 18 12:03:19 2022 -0600

Added type output with df command in fs-diskio.txt