Modularize Testcases - Githubissues

openSUSE / suse-doc-style-checker

Style Checker for SUSE Documentation

Other

2 stars 5 forks source link

Modularize Testcases #115

Closed tomschr closed 7 years ago

tomschr commented 7 years ago

This is a PR with the following benefits:

Modularized and splitted the bulky test_sdsc.py into different files to make the tests easier to read, extend, and to make it possible to run separately.
Simplified the diabolic test_xml() function and refactored into different functions. Looks much better IMHO now.

@sknorr: please review if you think this is useful (I hope so). :)

ghost commented 7 years ago

"Simplify the satanic test_xml() function" reveals theistic tendencies I would not have expected of you... :)

tomschr commented 7 years ago

"Simplify the satanic test_xml() function" reveals theistic tendencies I would not have expected of you... :)

:laughing: Well, after looking at the verbose for loops, I was searching for a good method to draw your attention. It seems it has worked quite good. :smile:

ghost commented 7 years ago

Thanks. I applied those manually, therefore closing this.