openSUSE / suse-xsl

DocBook XSL Stylesheets for SUSE branding
Other
11 stars 10 forks source link

Suppress sect2 inside preface TOC #426

Closed tomschr closed 3 years ago

tomschr commented 3 years ago

This PR fixes #425

tomschr commented 3 years ago

@cwickert I've added another alternative. The last commit 915d1aa enables the sections inside preface. Now we can decide which route we want to go. :wink: Actually, after looking at it, it's not so bad as I thought.

Here is a short screenshot:

Screenshot_20210204_163725

cwickert commented 3 years ago

I'm very much in favor of listing individual sections in preface. We can ask others for feedback or just go ahead.

What do you prefer?

ghost commented 3 years ago

I'd also suggest keeping preface/sect1 displayed & squashing the commits. Ideally, squash into two commits, one for the message change, the other for the actual selector change.

Otherwise, this looks good to me, thanks!

tomschr commented 3 years ago

We can ask others for feedback or just go ahead.

I did so in the SLE writers call. They are also in favor of the second option (with sections).

Ideally, squash into two commits, one for the message change, the other for the actual selector change.

Good idea, will do.


As all seemed to like a preface with sub sections, I'll merge this PR as soon as CI is finished.

Thanks to all!