openSUSE / suse-xsl

DocBook XSL Stylesheets for SUSE branding
Other
11 stars 10 forks source link

Fix #435: refactor intra-xref code #436

Closed tomschr closed 3 years ago

tomschr commented 3 years ago

Some xrefs were not detected as intra-xrefs.

TODOs:

tomschr commented 3 years ago

Okay... I've cleaned up the code and did some tests in HTML & FO:

Tests with normal and intra-xref Using this code inside `art_amd-sev.xml`: ```xml See . (xref pointing to a table in this article) See . (xref pointing into another chapter outside of this article) See . (xref directly to a book) See . (xref directly to an article) See . (xref pointing into another chapter outside of this article, but with xrefstyle) See (xref directly to an article, but with xrefstyle) ``` with this result: ![Screenshot_20210902_134841](https://user-images.githubusercontent.com/1312925/131838494-6dcc1956-8472-42df-81d2-ef7fc0085998.png)

The result is the same for HTML & FO. I still fear that I forget a test case. Tomas also tested it in the meantime and he didn't find anything.

@sknorr If you give your final okay, we could finish this PR soon. Are all of your issues resolved? Anything else you would like to see? Hope the indentation is correct now. :innocent:

Thanks!

tomschr commented 3 years ago

Many thanks Stefan!