openSUSE / suse-xsl

DocBook XSL Stylesheets for SUSE branding
Other
11 stars 10 forks source link

Need to rename @id -> @xml:id and @lang -> @xml:lang? #437

Closed tomschr closed 3 years ago

tomschr commented 3 years ago

Problem Description

The suse2021-ns stylesheets are "namespace aware", which means, you can use DocBook5 natively without any internal workarounds.

After looking a bit more closer today, I've recognized that some attributes should be prefixed with xml: (mainly xml:id and xml:lang).

I'm aware, that the stylesheets take into account both id and xml:id (and lang and xml:lang). However, I suspect, some convertion didn't catch all. Luckily, I found just a few.

List of files with id/lang ``` $ egrep -n "@id|@lang" suse2021-ns/*/*.xsl # removed any results that are correct suse2021-ns/fo/xref.xsl:227: select="$target.chapandapp/@id"/>') with a different language than the main book. suse2021-ns/xhtml/chunk-common.xsl:111: suse2021-ns/xhtml/chunk-common.xsl:112: suse2021-ns/xhtml/docbook.xsl:694: ```

Expected Behaviour

I guess, we want to add the xml: prefix, right?

ghost commented 3 years ago

Yes--the 2021 stylesheets are ns-only, so we definitely always want xml: namespaces in there.