search

openSUSE / suse-xsl

DocBook XSL Stylesheets for SUSE branding
Other
11 stars 10 forks source link

Hamburger icon not rendered clearly in HTML #539

Closed dariavladykina closed 1 year ago

dariavladykina commented 1 year ago

Problem Description

The hamburger icon, or three-dots menu - &hamburger-icon; - is almost not seen in HTML. It is visible in PDF. See the screenshots:

image

image

Expected Behavior

A larger image of hamburger icon for HTML.

tomschr commented 1 year ago

@dariavladykina Thanks Daria! :+1:

That's actually not a stylesheet issue. I found the Hamburger icon in doc-sle in the file xml/apps_firefox.xml. There you can find this entity:

<!ENTITY hamburger-icon "<inlinemediaobject xmlns='http://docbook.org/ns/docbook'><textobject role='description'><phrase>Three-lines button</phrase></textobject><imageobject role='fo'><imagedata fileref='hamburger_button.svg' width='0.8em' format='SVG'/></imageobject><imageobject role='html'><imagedata fileref='hamburger_button-fallback.png' width='1em' format='PNG'/></imageobject></inlinemediaobject>">

For HTML, you need to change the width="1em" to something else. I've tried it with 1cm and it looked good:

Screenshot_20230403_143335

I used the main branch.

If you can confirm, I'd like to close this issue. :slightly_smiling_face:

dariavladykina commented 1 year ago

Hi Toms,

Thanks very much for the explanation, I believe it's a typo by the author, so I informed them to correct the value. We can close the issue.

Thanks, Daria

From: Tom Schraitle @.> Sent: Monday, April 3, 2023 2:35 PM To: openSUSE/suse-xsl @.> Cc: Daria Vladykina @.>; Author @.> Subject: Re: [openSUSE/suse-xsl] Hamburger icon not rendered clearly in HTML (Issue #539)

Thanks Daria! 👍

That's actually not a stylesheet issue. I found the Hamburger icon in doc-sle in the file xml/apps_firefox.xml. There you can find this entity:

<!ENTITY hamburger-icon "Three-lines button">

For HTML, you need to change the width="1em" to something else. I've tried it with 1cm and it looked good:

[Screenshot_20230403_143335]https://user-images.githubusercontent.com/1312925/229510709-2762e85a-dfb5-470e-b41a-b08506ebafe9.png

I used the main branch.

If you can confirm, I'd like to close this issue. 🙂

— Reply to this email directly, view it on GitHubhttps://github.com/openSUSE/suse-xsl/issues/539#issuecomment-1494244368, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXSMEPUOJEQHMOL5OHXVPG3W7K72RANCNFSM6AAAAAAWRGIAW4. You are receiving this because you authored the thread.Message ID: @.***>