Open tomschr opened 4 months ago
Hi Toms, in the resulting HTML please replace the class name 'variablelist' with the class name 'tab-structure'. Resulting HTML for your reference:
<div class="tab-structure">
<ul class="tabs">
<li class="tab active-tab" onclick="showTabContent(event)">Geeko</li>
<li class="tab" onclick="showTabContent(event)">Geeko 2</li>
<li class="tab" onclick="showTabContent(event)">Geeko 3</li>
</ul>
<div class="content-container">
<div id="tabContent1" class="tab-content">
<p>The SUSE mascot 1</p>
</div>
<div id="tabContent2" class="tab-content" style="display: none;">
<p>The SUSE mascot 2</p>
</div>
<div id="tabContent3" class="tab-content" style="display: none;">
<p>The SUSE mascot 3</p>
</div>
</div>
</div>
replace the class name 'variablelist' with the class name 'tab-structure'.
That's now added in commit 2287a1a.
Apart from this change, I came across that the Bulma framework (which we use) support tabs already (https://bulma.io/documentation/components/tabs/)...
The question is, should we revisit this idea and do it the "Bulma way"? If possible, we shouldn't reinvent the wheel. However, that maybe comes with a price:
On the other side, we could gain something as well:
I was hesitant to commit it, so I post the diff of the change here:
diff --git i/source-assets/styles2022/sass/style.sass w/source-assets/styles2022/sass/style.sass
index 59fea29..69cda95 100644
--- i/source-assets/styles2022/sass/style.sass
+++ w/source-assets/styles2022/sass/style.sass
@@ -134,9 +134,15 @@ $i_page_width_wide: $i_superwide
// Upstream imports (must be first!)
-//@import "bulma-0.9.3/bulma/bulma.sass"
+// @import "bulma-0.9.3/bulma/bulma.sass"
+@import "bulma-0.9.3/bulma/sass/utilities/controls"
+@import "bulma-0.9.3/bulma/sass/utilities/extends"
+
@import "bulma-0.9.3/bulma/sass/base/minireset.sass"
@import "bulma-0.9.3/bulma/sass/elements/container.sass"
+@import "bulma-0.9.3/bulma/sass/components/tabs.sass"
Changes
Assume you have the following
<variablelist>
:The change in the template converts it into this HTML structure:
TODOs
source-assets/styles2022/sass/custom/content-formal-informal.sass
)suse2022-ns/static/js/script.js
)Related items
Related to #606