search

openSUSE / travel-support-program

A rails app to support the travel support program of openSUSE (TSP)
https://tsp.opensuse.org/
GNU Affero General Public License v3.0
17 stars 21 forks source link

Configure the available types of requests #21

Closed ancorgs closed 8 years ago

ancorgs commented 8 years ago

@tsdgeos This one is for you :wink: I saw in the diff you sent me that you also commented everything about merchandising shipment requests, because you don't use that feature. Thus I created this branch (which is actually branched from the requester_is_not_a_role branch already commented in the issue#17) https://github.com/openSUSE/travel-support-program/tree/optional_requests

With that code, you can use the config/site.yml to disable the travel support requests or the shipment ones. Beware, as a consequence if the new feature, the format of that file has changed slightly, so take a look to the changes in config/site.example.yml if you are planing to reuse your old configuration.

When enabling/disabling types of requests, everything (even the user guide that is used as landing page) should adapt gracefully to the possible combinations (i.e. only travel support, only shipments or both).

So please review. If you are fine with the changes (in both issues/branches), I'll merge everything into master.

tsdgeos commented 8 years ago

looks good :)

tsdgeos commented 8 years ago

Should we close this too?

ancorgs commented 8 years ago

Right!