search

openSUSE / wicked

Framework for network configuration
https://en.opensuse.org/Portal:Wicked
GNU General Public License v2.0
101 stars 50 forks source link

TODO: LLDP and DCBX #33

Open olafhering opened 10 years ago

olafhering commented 10 years ago

From TODO file:

okirch commented 10 years ago

On Tuesday 05 November 2013 17:17:15 olafhering wrote:

From TODO file:

  • LLDP and DCBX:
    • Basic LLDP code is there, as well as DCBX TLV encoding/decoding
      • Above all, this needs testing
      • There should be a global setting for enabling/disabling LLDP tx and rx.
  • When a NIC does not support DCB, we spit out an ugly error message. We should not do this
  • When receiving a DCBX message, we currently update the operating params, but never write them back to the kernel.

The last one is probably the most pressing issue. For lack of a card to test with, I never implemented this.

Olaf

Neo didn't bring down the Matrix. SOA did. (soafacts.com)

Olaf Kirch - Director SUSE Linux Enterprise; R&D (okir@suse.com) SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)

olafhering commented 10 years ago

where are DCBX messages received in current code?

okirch commented 10 years ago

On Thursday 07 November 2013 13:55:52 olafhering wrote:

where are DCBX messages received in current code?

DCB attributes are part of the 802.1 TLV; the parsers are in the table inside ni_lldp_tlv_get_ieee_802_1() in lldp.c.

There is at least one more standard for DCB, placing these attributes in a different TLV. But from what I understood, the 802.1 TLV is the one that every vendor should/does support. All the other solutions were interim only, before DCB made it into the IEEE 802.1 standard.

The function to process the updated attributes is ni_dcbx_update_remote in src/dcb.c

Olaf

Neo didn't bring down the Matrix. SOA did. (soafacts.com)

Olaf Kirch - Director SUSE Linux Enterprise; R&D (okir@suse.com) SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)

olafhering commented 10 years ago

How can we actually test the functionality? Its my understanding that a given host reacts to events from outside. Do we have any contacts to hardware/software vendors who can verify our lldp/dcbx functionality?

okirch commented 10 years ago

On Friday 08 November 2013 10:04:22 olafhering wrote:

How can we actually test the functionality? Its my understanding that a given host reacts to events from outside. Do we have any contacts to hardware/software vendors who can verify our lldp/dcbx functionality?

Hannes has the hardware and the switches to test this stuff. DCB is a key requirement for FCoE, as far as I understood.

Olaf

Neo didn't bring down the Matrix. SOA did. (soafacts.com)

Olaf Kirch - Director SUSE Linux Enterprise; R&D (okir@suse.com) SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)

olafhering commented 10 years ago

I have added some code to my olh_dcbx_options_back_to_kernel branch.