openSUSE / wicked

Framework for network configuration
https://en.opensuse.org/Portal:Wicked
GNU General Public License v2.0
98 stars 49 forks source link

remove port arrays and cleanup interface dependencies (bsc#1205604) #990

Closed mtomaschewski closed 2 months ago

mtomaschewski commented 8 months ago
mtomaschewski commented 8 months ago

Fixed an issue causing to report errors (and twice) when a blacklisted ifcfg file like *.bak created by firewalld exists:

Oct 20 11:32:39 install wicked[4871]: Rejecting blacklisted ifcfg-file: /etc/sysconfig/network/ifcfg-ens4.bak
Oct 20 11:32:39 install wicked[4871]: Failed to read ifcfg-file '/etc/sysconfig/network/ifcfg-ens4.bak': No such file or directory
mtomaschewski commented 7 months ago

The commit 8c1631b is an issue that happens also with master, this branch increases it's probability.

JeffreyCheung commented 5 months ago

Hi @cfconrad , can you kindly provide the PR review for @mtomaschewski please , thanks :)

cfconrad commented 5 months ago

hi, @JeffreyCheung sorry for not been transparent here, but @mtomaschewski and I are working heavily on this PR offline. As you can imaging this big change need a lot of testings (manual and automated). So plz stay tuned we are on it!

JeffreyCheung commented 5 months ago

Thank @cfconrad , very much appreciated :)