search

openSUSE / wiki

openSUSE Wiki
http://en.opensuse.org
25 stars 17 forks source link

Style updates for new skin #12

Closed guoyunhe closed 7 years ago

guoyunhe commented 7 years ago

After trying on en-test.opensuse.org, I found and fixed some layout bugs. Things fixed and improved are:

  1. Load styles and scripts separately. Styles should be load on the top, so HTML won't render before styles were loaded. Scripts should be loaded at the bottom to avoid waiting.
  2. Hide dropdown button on page actions if here is no action at all. Action buttons are smaller than before.
  3. Fix several class name mistakes in HTML. Duplicate or missing class="" property will cause style problem.
  4. Avatar is bigger than before. Login button and user menu button use an outstanding color.
  5. Page title is smaller.

spectacle bh7468

guoyunhe commented 7 years ago

New changes:

  1. Use JavaScript to remove some MediaWiki classes that override skin styles
  2. Use JavaScript to adjust card images and links. Also remove unnecessary <p> tag generated by MediaWiki.
  3. Clear float for categories links
cboltz commented 7 years ago

I'm not the biggest fan of removing CSS classes via wiki.js - but until we find a better solution (which would ideally let MediaWiki create the code we need), I can live with it.

Besides that, I didn't notice any issues and will submit a new mediawiki_1_27-openSUSE package in some minutes.

Note: I have to change the text in the copyright footer, so please merge this from the upstream repo in some minutes ;-)