search

openSUSE / zypper

World's most powerful command line package manager
http://en.opensuse.org/Portal:Zypper
Other
412 stars 113 forks source link

Don't print reboot required message when only downloading #529

Closed jubalh closed 8 months ago

jubalh commented 10 months ago

Since we are only downloading and not installing there is no reboot required.

jubalh commented 8 months ago

@mlandres ping

mlandres commented 8 months ago

Sorry, I forgot to add a comment.

I see the point, but for other messages - like package manager restart needed - the same could be true. But more important that many people use a combination of --dry-run --downlod-only because this also performs the fileconflict check after downloading. And with dry-run you may want to see what would happen if... even if it's not performed now.

That's why I added a line before the continue prompt which tells whether some of the fake options are in use:

Note: System reboot required.

Backend:  classic_rpmtrans --download-only
Continue? [y/n/v/...? shows all options] (y):

We could perhaps also refine the note rather than suppressing it.

jubalh commented 8 months ago

So should I not just check whether --dry-run is used?

mlandres commented 8 months ago

No. I'll change the notification texts to reflect that this is what would be needed if download-only/dry-run were not active.

This way one can see what would be needed if the transaction would be applied and it should be clear that it does not apply to the current command. I think that's better than hiding the message.

jubalh commented 8 months ago

Alright!