openT2T / translators

Repository for Open Translators to Things.
http://www.opentranslatorstothings.org
Other
29 stars 27 forks source link

Manifests missing resources, and referencing resources that do not exist. #213

Open danielrischar opened 7 years ago

danielrischar commented 7 years ago
  1. Missing completely (partial list):

    • oic.r.colour.chroma
    • oic.wk.d
    • oic.wk.p
    • opent2t.platform
  2. Many manifest.xml files are missing resources referenced by their platform schemas. This file is read by the LocalPackageSource and in order to create the translator packages, so as a result our translators are incomplete. Manifest.xml must list all dependencies (like core, base, resource, link, wk.d, wk.p, etc). OcfSchemaReader already exists in the opent2t library to dereference JSON schemas. This could be used to generate a list of dependencies rather than having to explicitely call them out in the manifest. The current way of doing this tries to keep the same information in at least two places.

  3. Using OcfSchemaReader to dereference a platform schema (like org.opent2t.sample.lamp.superpopular) fails at this point because it cannot find the referenced schemas.

  4. colourRGB is also mispelled.

I recommend that we move all resource definitions under another folder (translators/resources). They only exist at the root for pack-translator.js to pick up. Otherwise, it needlessly increases the number of directories in the translators repo.