openT2T / translators

Repository for Open Translators to Things.
http://www.opentranslatorstothings.org
Other
29 stars 27 forks source link

Handling missing translators in getPlatforms (wink) #216

Closed danielrischar closed 7 years ago

arjun-msft commented 7 years ago

:shipit:

shalinijoshi19 commented 7 years ago
getPlatforms(expand, payload, verification) {

Can you update the hubController tests to test for this condition? #Resolved


Refers to: org.opent2t.sample.hub.superpopular/com.wink.hub/js/thingTranslator.js:61 in 20d0e8b. [](commit_id = 20d0e8b12c1156b7d39550f35e3061d988c4cfc3, deletion_comment = False)

shalinijoshi19 commented 7 years ago
getPlatforms(expand, payload, verification) {

i guess here it makes sense to update the hub unit tests. And in the cloud repo update the hubcontroller tests to ensure the end-end scenario has the desired result


In reply to: 288218653 [](ancestors = 288218653)


Refers to: org.opent2t.sample.hub.superpopular/com.wink.hub/js/thingTranslator.js:61 in 20d0e8b. [](commit_id = 20d0e8b12c1156b7d39550f35e3061d988c4cfc3, deletion_comment = False)

shalinijoshi19 commented 7 years ago

:shipit: