Closed tjaffri closed 8 years ago
@jasongin and @sanjaiganesh I was doing some other dir structure renaming work with @arjun-msft and @jeanpa and we STUBBED OUT some of this stuff. I haven't made all the changes like updating the test automation and the actual deviceTranslator implementation but let's huddle to see if you can reuse some of my stub.
We need to clarify the usage of <schema>
elements in the manifest.
In my opinion, the manifest only needs to reference the .raml file. I don't see any reason to duplicate all of the direct and indirect references to .json schema files (a flattened schema dependency tree) in the manifest.
Here are some notes on the <schema>
elements in the manifest:
org.opent2t.sample.thermostat.superpopular
Let's stick with the above for now, which should serve our purposes. Clearly we need to keep thinking about the manifest.xml format but we will learn once we have things working e2e.
Basic version of this is done, so I am closing it out. Will file a new issue to finish this implementation with any other schema attributes we want to add.
44 is creating the thermostat schema in OCF format.
In parallel, we need to update one translator (let's pick the Wink Thermostat Translator for ease) to implement that schema. This includes:
Updating the manifest file
The
manifest.xml
needs to reference the OCF schema(s), where it currently only references a single AllJoyn schema.For example:
Note that we are OK (for now) duplicating the fact the dimming and binary will likely be $ref inside org.OpenT2T.Sample.SuperPopular.Lamp but will also be duplicated under schemas. We can discuss this further at a later date.
Updating the methods in the translator itself
We need to update the translator methods to correspond to the RAML (get/put pattern) in OCF.