openTCS / opentcs

The open Transportation Control System (by Fraunhofer IML)
https://www.opentcs.org/
MIT License
324 stars 114 forks source link

Published Events no longer have Type info even though it is in the documentation #77

Closed jfaigan closed 1 year ago

jfaigan commented 1 year ago

Affected version

Name the affected version, i.e. "release x.y.z" or "revision ". 5.7.0 ...

Steps to reproduce

How can the incorrect behaviour be reproduced?

  1. Use the API to listen to the Events
  2. Type element is missing from all types (TransportOrder, Vehicle and PeripheralJob)
  3. ...

Expected behaviour

What would be the correct/expected behaviour?

Type element should be provided as per the API documentation

Actual behaviour

What behaviour can actually be observed instead of the correct behaviour?

Type element is not in the returned json

Additional information

Other data that can help with fixing the defect, e.g. logs, screenshots etc. image image

swltr commented 1 year ago

@jfaigan Thanks for the report! I assume this still worked with 5.6.0?

jfaigan commented 1 year ago

No problem. Yes, I have both 5.6 and 5.7 running in parallel on different ports.

Here is what 5.6 yields: image

swltr commented 1 year ago

This has been fixed with b3a80d1b767f90a7790ac378d7e88107d1ad5482 for 5.8, which we can hopefully finalize real soon now.