openTdataCH / ojp-nova

Interface between OJP and NOVA to return an OJPFareDelivery
1 stars 0 forks source link

HTTPS: How will we do https? #16

Closed ue71603 closed 1 year ago

ue71603 commented 1 year ago

We need a longer call in server.py: uvicorn.run( 'main:app', port=443, host='0.0.0.0', reload=True, reload_dirs=['html_files'], ssl_keyfile='/path/to/certificate-key.pem', ssl_certfile='/path/to/certificate.pem')

and we need ssl_key/certificate. I think we can only do this later. Perhaps we need a switch that tells if the service should be http or https: I will add some parts now.

skinkie commented 1 year ago

What do you mean exactly?

ue71603 commented 1 year ago

at some point the service should not be http but https, I guess. Currently http is hardcoded

skinkie commented 1 year ago

You mean accessing upstream?

ue71603 commented 1 year ago

implemented it.