search

openTdataCH / ojp-sdk

Meta OJP SDK repo
MIT License
4 stars 0 forks source link

LIR Circle with Type=address doesnt respect the Circle area #17

Open vasile opened 2 months ago

vasile commented 2 months ago

https://tools.odpch.ch/ojp-api-explorer-v2/?gist=98e22bc3de8d170dc9ec19e19df90c4e

image

The filter seems to use a rectangle instead of circle

<GeoRestriction>
  <Circle>
    <Center>
      <siri:Longitude>7.416356</siri:Longitude>
      <siri:Latitude>46.926923</siri:Latitude>
    </Center>
    <Radius>200</Radius>
  </Circle>
</GeoRestriction>

Request /POST https://api.opentransportdata.swiss/ojp20 XML: https://gist.github.com/vasile/98e22bc3de8d170dc9ec19e19df90c4e

TO-mdv commented 2 months ago

@vasile in the Request, you search for a radius of 200m -> diameter of 400m. All the results seems to be in the diameter 400m: image

It seems like your visualizer (which by the way is verry cool!) shows only a radius of 100m, could that be?

vasile commented 2 months ago 
It seems like your visualizer (which by the way is verry cool!) shows only a radius of 100m, could that be?

Hi @TO-mdv - it should be 200m, if you compare with the scale control

image
TO-mdv commented 2 months ago

Ah yes, you are right. Maybe our Application swaps radius and diameter, I check that.

TO-mdv commented 2 months ago

Bug created: SH-2893 OJP2.0 LIR liefert Ergebnisse ausserhalb Circle -> LIR-2e_Address_Circle

vasile commented 2 months ago

Thanks for the follow-up @TO-mdv - however please assign it with low-priority because Rectangle GeoRestriction is used for now.

TO-mdv commented 2 weeks ago

Fixed on INT, Release in PROD 25.7.2024

Some elements are still out of the Circle, because the street cut the circle somewhere at beginning:

Image