search

openTdataCH / ojp-sdk

Meta OJP SDK repo
MIT License
4 stars 0 forks source link

Disruption Messages are missing the reference within the affected trips <ojp:SituationFullRef> #69

Closed bls-marco closed 2 months ago

bls-marco commented 3 months ago

Currently we can't map the SIRI-SX disruption message to the relevant trips. The delivers the message but as the with the "sstid" is missing on PROD and INT.

We checked on OJP V1 this reference is deliverd within the service part of a trip leg. 

<ojp:Service>
                  <ojp:OperatingDayRef>2024-07-26</ojp:OperatingDayRef>
                  <ojp:JourneyRef>ojp-96-200-7-j24-1-28-TA</ojp:JourneyRef>
                  <siri:LineRef>ojp:96200:7</siri:LineRef>
                  <siri:DirectionRef>R</siri:DirectionRef>
                  <ojp:Mode>
                    <ojp:PtMode>bus</ojp:PtMode>
                    <siri:BusSubmode>localBusService</siri:BusSubmode>
                    <ojp:Name>
                      <ojp:Text xml:lang="de">Bus</ojp:Text>
                    </ojp:Name>
                    <ojp:ShortName>
                      <ojp:Text xml:lang="de">B</ojp:Text>
                    </ojp:ShortName>
                  </ojp:Mode>
                  <ojp:PublishedLineName>
                    <ojp:Text xml:lang="de">833</ojp:Text>
                  </ojp:PublishedLineName>
                  <ojp:OperatorRef>ojp:801</ojp:OperatorRef>
                  <ojp:Attribute>
                    <ojp:Text>
                      <ojp:Text xml:lang="de">Niederflureinstieg</ojp:Text>
                    </ojp:Text>
                    <ojp:Code>A__NF</ojp:Code>
                  </ojp:Attribute>
                  <ojp:DestinationStopPointRef>8573286</ojp:DestinationStopPointRef>
                  <ojp:DestinationText>
                    <ojp:Text xml:lang="de">Weinfelden</ojp:Text>
                  </ojp:DestinationText>
                  <ojp:SituationFullRef>
                    <siri:ParticipantRef>ski-ddip-out-sx_prod</siri:ParticipantRef>
                    <siri:SituationNumber>ch:1:sstid:100602:prod:66a240012ab79c02f03e3228-0</siri:SituationNumber>
                  </ojp:SituationFullRef>
                </ojp:Service>

But the same connections in V2, which contains the message, but is missing the reference on the same leg.

<Service>
                  <Mode>
                    <PtMode>bus</PtMode>
                    <siri:BusSubmode>localBus</siri:BusSubmode>
                    <Name>
                      <Text xml:lang="de">Bus</Text>
                    </Name>
                    <ShortName>
                      <Text xml:lang="de">B</Text>
                    </ShortName>
                  </Mode>
                  <ConventionalModeOfOperation>scheduled</ConventionalModeOfOperation>
                  <TrainNumber>83318</TrainNumber>
                  <siri:LineRef>ojp:96200:7</siri:LineRef>
                  <siri:OperatorRef>801</siri:OperatorRef>
                  <PublicCode>Bus</PublicCode>
                  <PublishedServiceName>
                    <Text xml:lang="de">833</Text>
                  </PublishedServiceName>
                  <ProductCategory>
                    <Name>
                      <Text xml:lang="de">Bus</Text>
                    </Name>
                    <ShortName>
                      <Text xml:lang="de">B</Text>
                    </ShortName>
                    <ProductCategoryRef>29</ProductCategoryRef>
                  </ProductCategory>
                  <siri:DirectionRef>R</siri:DirectionRef>
                  <OperatingDayRef>2024-07-26</OperatingDayRef>
                  <DestinationStopPointRef>8573286</DestinationStopPointRef>
                  <OriginText>
                    <Text xml:lang="de">n/a</Text>
                  </OriginText>
                  <DestinationText>
                    <Text xml:lang="de">Weinfelden</Text>
                  </DestinationText>
                  <JourneyRef>ojp-96-200-7-j24-1-28-TA</JourneyRef>
                  <Attribute>
                    <UserText>
                      <Text xml:lang="de">Niederflureinstieg</Text>
                    </UserText>
                    <Code>A__NF</Code>
                  </Attribute>
                </Service>

The issue can also be understood and checked within the Demo Web App

OJP V1 Beta

26-07-2024_13-12-21

OJP V2

26-07-2024_13-11-55

TO-mdv commented 3 months ago

Bug erstellt: SH-3333 OJP2.0 TR AddInfo missing SituationFullRef

TO-mdv commented 3 months ago

Element ist nun am Leg vorhanden:

    <Attribute>
        <UserText>
            <Text xml:lang="de">Aussteigeseite: Links</Text>
        </UserText>
        <Code>ojp91061AR_InfoCall296_111340_1</Code>
    </Attribute>
    <SituationFullRefs>
        <SituationFullRef>
            <siri:ParticipantRef>ski-ddip-out-sx_test</siri:ParticipantRef>
            <siri:SituationNumber>ch:1:sstid:100001:dccd662a-e519-468b-b06b-1fdb25727282-1</siri:SituationNumber>
        </SituationFullRef>
    </SituationFullRefs>
</Service>
<LegTrack>
TO-mdv commented 3 months ago

Release 12.8.2024 (30-stable)