openactive / OpenActive.Server.NET

.NET server library, including an OpenActive Reference Implementation
MIT License
0 stars 7 forks source link

Add idempotency protection to B #145

Closed matdavies closed 1 year ago

matdavies commented 3 years ago

When finished, should fix #100

Currently draft format. Per the comment here, I have attempted to change the return type of ProcessFlowResult. Could not just return a string, as ProcessCheckpoint uses the orderQuote to determine the HttpStatusCode to return, so added a ProcessFlowResult object to contain both the string to return and this value.

I'm not sure about this though, design-wise, as it is adding an Http dependency to the CustomBookingEngine which may violate some design principles here, so throwing this up as a draft for review.

nickevansuk commented 1 year ago

Closing as this has now been mostly implemented in #207, with a separate issue to capture the remaining functionality created in #208.

Thanks so much for your work on this all those years ago @matdavies !