search

openactive / OpenActive.Server.NET

.NET server library, including an OpenActive Reference Implementation
MIT License
0 stars 7 forks source link

Consolidated packages #192

Open MarkCiliaVincenti opened 1 year ago

MarkCiliaVincenti commented 1 year ago

Please note that some other packages are marked as having vulnerabilities and should be updated.

MarkCiliaVincenti commented 1 year ago

@nickevansuk can you check if CI works with this?

MarkCiliaVincenti commented 1 year ago

@nickevansuk ?

MarkCiliaVincenti commented 1 year ago

So all I did here was open VS2022, opened "Manage NuGet Packages for Solution", went on the Consolidate tab and consolidated 2 packages. CI should really not be failing here.

nickevansuk commented 1 year ago

.NET Framework is indeed fickle

MarkCiliaVincenti commented 1 year ago

.NET Framework is indeed fickle

Are you entirely sure that the current build passes CI? Could the problem be with the CI rather than the code changes?

nickevansuk commented 1 year ago

It's possible something else is broken here for sure - will add it to the backlog to investigate

MarkCiliaVincenti commented 1 year ago

It's possible something else is broken here for sure - will add it to the backlog to investigate

Probably this commit: https://github.com/openactive/OpenActive.Server.NET/commit/119c30e67f98b84e71d64413bad63dd6eb80dfaf

MarkCiliaVincenti commented 1 year ago

@nickevansuk I see you removed your assignment yesterday; did you figure out the issue?

nickevansuk commented 1 year ago

Not yet - that was just as it's on the backlog. Hoping to get some time to look at this in the next couple of weeks so will keep you posted!