However, the Reference Implementation contained in this project creates accessCodes with "value": "defaultValue". And so, merging the Data Models update into Test Suite leads to CI failing for both Test Suite and this project.
Here is what the CI error looks like when Test Suite runs with the Data Models changes pulled in. Every test that incidentally involves an accessCode being returned at some point fails:
And here's what the data looks like in the B response that triggered that error:
EDIT: ALSO, When this issue is complete, could you revert this revert in Test Suite: https://github.com/openactive/openactive-test-suite/pull/581. This will bring Test Suite up to date with Data Models changes
A recent Data Models update (https://github.com/openactive/data-models/pull/113) has removed
valuefromPropertyValue, which is not a part of this object (see spec: https://openactive.io/open-booking-api/EditorsDraft/1.0CR3/#text-based-access-control).However, the Reference Implementation contained in this project creates
accessCodes with"value": "defaultValue". And so, merging the Data Models update into Test Suite leads to CI failing for both Test Suite and this project.Here is what the CI error looks like when Test Suite runs with the Data Models changes pulled in. Every test that incidentally involves an accessCode being returned at some point fails:
And here's what the data looks like in the B response that triggered that error: