openactive / data-model-validator

The OpenActive data model validator library
MIT License
1 stars 1 forks source link

"A SessionSeries must have an eventSchedule or at least one subEvent." ...Must it though? #340

Open lukehesluke opened 4 years ago

lukehesluke commented 4 years ago

This was introduced here: https://github.com/openactive/data-model-validator/issues/205

This rule mandates that a SessionSeries MUST have accompanying when information (in the form of subEvent items of an eventSchedule).

Due to the number of occurrences that a single SessionSeries can have (e.g. Swimming lessons in a leisure centre. There may be dozens of ScheduledSessions per week that are all children of the one SessionSeries), many RPDE feeds that I've seen have been split into:

  1. What / Where information: e.g. a SessionSeries feed or a FacilityUse feed
  2. When information e.g. a ScheduledSession feed or a FacilityUse/Slot feed

If it were not done in this way, then SessionSeries with a large number of ScheduledSession children would appear in a feed as a very large object and may reappear frequently due to updates to individual ScheduledSessions.

As a result, the What / Where feed can very reasonably include SessionSeries that have no subEvent items (ScheduledSessions or Events could be in a separate feed which reference the SessionSeries using the superEvent feed) nor an eventScheduled

Therefore, I wonder if this rule should be removed?

lukehesluke commented 4 years ago

The rule is defined here: https://github.com/openactive/data-model-validator/blob/master/src/rules/data-quality/session-course-has-subevent-or-schedule-rule.js