openactive / developer-documentation

Developer documentation synced with GitBook and the Data Models
https://developer.openactive.io/
MIT License
0 stars 3 forks source link

Add documentation for data users to ensure they use BigInt when processing RPDE modified to prevent overflow in languages where the default integer type would overflow #56

Closed lukehesluke closed 1 year ago

lukehesluke commented 1 year ago

This is caused primarily by SQL Server’s timestamp or rowversion (as referenced here), which is cast to a SQL Server BIGINT on the way out of the db (SELECT CAST([version] AS BIGINT) FROM [dbo].[mytable])

Raise an issue for RPDE that limits the modified and id to be 64-bit if they are numbers (what to do for JS, C#, etc)


Add to this branch of the gitbook project for dev docs 268 (https://app.gitbook.com/o/-LJTExWaXZFqcFJ_lZwF/s/-LOMz1IIOd5fl4xzfUYb/~/changes/268/using-data/harvesting-opportunity-data-1)


Output:

lukehesluke commented 1 year ago

This issue should be close-able when the draft https://app.gitbook.com/o/-LJTExWaXZFqcFJ_lZwF/s/-LOMz1IIOd5fl4xzfUYb/~/changes/268/using-data/harvesting-opportunity-data is merged

nickevansuk commented 1 year ago

Merged, looks great 👍