nickevansuk
commented
7 years ago Closed nickevansuk closed 1 year ago
nickevansuk
commented
7 years ago nickevansuk
commented
7 years ago This looks good, one issue outstanding:
We're about to draft a new version of the standard, so to keep this in line with that (so that you're ahead of this), please also add a license to each page as follows:
{
"next": null,
"items": [
{
...
}
],
"license": "https://creativecommons.org/licenses/by/4.0/"
}This will license the content as open data under CC BY v4.
See the issue in the main spec for more info: https://github.com/openactive/realtime-paged-data-exchange/issues/34
nickevansuk
commented
7 years ago For arrays representing key value pairs, it would be clearer that the keys are reliable to code against (rather than entered by the user) if they are represented as a map rather than an array. I understand that the keys are not customisable by the user, and are predefined. So this example:
"FacilitySpecifics": [
{
"Key": "Area",
"Value": "157.5"
},
{
"Key": "Diving boards",
"Value": "0"
},
{
"Key": "Lanes",
"Value": "4"
},
{
"Key": "Length",
"Value": "17.5"
},
{
"Key": "Maximum depth",
"Value": "1.5"
},
{
"Key": "Minimum depth",
"Value": "1.5"
},
{
"Key": "Movable floor",
"Value": "0"
},
{
"Key": "Width",
"Value": "9"
}
]Should instead be:
"FacilitySpecifics": {
"area": "157.5",
"divingBoards": "0",
"lanes": "4",
"length": "17.5",
"maximumDepth": "1.5",
"minimumDepth": "1.5",
"movableFloor": "0",
"width": "9"
}Where keys are only present if they are relevant to that particular facility.