search

openactive / open-booking-api

Repository for the Open Booking API specification
Other
2 stars 3 forks source link

Add https://openactive.io/OrderItemRejected #154

Closed nickevansuk closed 3 years ago

nickevansuk commented 3 years ago

Add https://openactive.io/OrderItemRejected to OrderItemStatus, for OrderItems that have been rejected from OrderItemProposed state.

Correct typo schema:OrderItemStatus to oa:OrderItemStatus.

nickevansuk commented 3 years ago

On reflection, perhaps this approach is a more consistent one to take?

Otherwise we're duplicating the state of the OrderProposal across the OrderItem and the Order?

Clarify that if an OrderProposal is rejected its orderItemStatus should still be "https://openactive.io/OrderItemProposed".

The status of an OrderItem with orderItemStatus of "https://openactive.io/OrderItemProposed" is defined by its Order's orderProposalStatus value, e.g. https://openactive.io/AwaitingSellerConfirmation or https://openactive.io/OrderItemRejected.

This is already inferred by the current specification but should be made clearer.

Raised as a separate issue: https://github.com/openactive/open-booking-api/issues/157

nickevansuk commented 3 years ago

Raised the other aspect of this issue as #182 in order to close this issue as a duplicate.