openactive / open-booking-api

Repository for the Open Booking API specification
Other
2 stars 3 forks source link

SellerMismatchError and SellerNotFoundError has status code 500 when it should have 4xx #185

Open civsiv opened 3 years ago

civsiv commented 3 years ago

When making a C1 call, I received a 500 status code for a SellerMismatchError. I am unsure where this is defined in the specification but it should not be a 500. I would guess that it should be a 400 Bad Request, but at the very least it should be 4xx

Screenshot 2020-11-23 at 15 11 04

nickevansuk commented 2 years ago

Note this also applies to SellerNotFoundError

nickevansuk commented 1 year ago

Also applies to OrderAlreadyExistsError and OrderProposalVersionOutdatedError which should be 409s. The 500s in the spec, except for subclasses of InternalOpenBookingError , should be reviewed should see if they should in fact be 4xx errors.