search

openactive / open-booking-api

Repository for the Open Booking API specification
Other
2 stars 3 forks source link

Customer optional for Order (and OrderQuote) #200

Open civsiv opened 3 years ago

civsiv commented 3 years ago

Proposal

The property customer must be optional for Order (and any type that subclasses it like OrderQuote).

Justification

When the broker is a ResellerBroker the customer property in Order is optional due to the nature of the relationship between the broker and the seller. The Modelling Spec clearly states this in section 6.1.5.

However in the model definition of Order it is stated that customer is a Required property. This can be seen in section 10.1.1. This is what must be changed.

nathansalter commented 3 years ago

Surely in this case the customer would be the seller Organization that is placing the booking?

nickevansuk commented 3 years ago

That would be the broker as per the spec: see https://openactive.io/open-booking-api/EditorsDraft/1.0CR3/#scope-of-specification and https://openactive.io/open-booking-api/EditorsDraft/1.0CR3/#conformance-criteria