openactive / realtime-paged-data-exchange

OpenActive Realtime Paged Data Exchange Specification
https://www.openactive.io/realtime-paged-data-exchange/
Other
6 stars 1 forks source link

Additional properties in RPDE response #86

Open nickevansuk opened 6 years ago

nickevansuk commented 6 years ago

From @ldodds "There are now three optional properties for feeds which indicate version number of specifications in use, and the types of entity included in a feed. Details can be found in the table here: https://www.openactive.io/realtime-paged-data-exchange/EditorsDraft/#response-grammar"

nickevansuk commented 6 years ago

Some thoughts on each property

version

opportunityModelVersion

feedObjects naming

feedObjects too early?

ldodds commented 6 years ago

re: version of spec in dataset metadata, that metadata is not discoverable from the feed itself. The RPDE spec also doesn't indicate that dataset level metadata should be published. So I don't think its redundant to include the version of the spec in the feed itself.

Using URIs versus version numbers seems like a good idea, happy to make that change.

Also happy to use a general model or dataModel property to identify the model of the data.

But I think a consumer might reasonably want to know what type of thing it should be harvesting so something like feedObjects (or similar named property) is necessary.

As I commented in #84 I think kind should be re-thought. A list of types at the feed level, and a requirement to have a type property (of some form) in the data achieves the same goal. Schema.org is serving us well elsewhere, so I'd feel comfortable about recommending it's use here.